OSCommerce Product Manager

OSCommerce Product Manager for Windows
Tasklist

FS#92 - Product description limited at 1024 characters.

Attached to Project: OSCommerce Product Manager
Opened by Mario A. Valdez-Ramirez (mvaldez) - Friday, 27 August 2004, 12:05 GMT-6
Last edited by Mario A. Valdez-Ramirez (mvaldez) - Friday, 27 August 2004, 17:50 GMT-6
Task Type Bug Report
Category Backend / Core
Status Closed
Assigned To Mario A. Valdez-Ramirez (mvaldez)
Operating System All
Severity Low
Priority Immediate
Reported Version any
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The TMemo control for the product description in the PEdit form is being limited to 1024 characters. The limit of a TMemo field are 32K for W9x and 64 for W2K/XP. Something is wrong.

Pending to test.
This task depends upon

Closed by  Mario A. Valdez-Ramirez (mvaldez)
Friday, 27 August 2004, 17:50 GMT-6
Reason for closing:  
Comment by Mario A. Valdez-Ramirez (mvaldez) - Friday, 27 August 2004, 17:50 GMT-6

I've just discovered the reason.
The constant opmC_ProdDescription_MaxLen in oscpmdata.pas defines the max allowed size of product description as 1024. I have increased it to 32000 (to be safe on the Win9x limit).

After reviewing the paper docs, the requirement list mentioned something about truncating all fields before feeding them to the SQL server, it could be between the memory structures and the UI or between the SQL server and the memory structures. We choosed the first option (because allowed us to provide immediate feedback to the user).

The limits to use were based on the database table structure, except with memo fields; for them there is no mention about the max size. It seem we decided that 1024 was good enough. We were wrong.

Oops.

I'm closing this as fixed.

Loading...